Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable ad refresh for A-Frame and Wonderland Engine #207

Merged
merged 11 commits into from
May 10, 2024
Merged

Enable ad refresh for A-Frame and Wonderland Engine #207

merged 11 commits into from
May 10, 2024

Conversation

msub2
Copy link
Contributor

@msub2 msub2 commented May 10, 2024

This implements ad refreshing if the banner is in view, checking every 30 seconds. It also fixes a scaling issue on A-Frame with prebid banners that do not have absolute dimensions.

Copy link
Contributor

@limbofeather limbofeather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit but otherwise LGTM, a short description for the PR would be nice to give more context if there's anything that you want there.

aframe/src/index.js Outdated Show resolved Hide resolved
wonderland/src/index.js Outdated Show resolved Hide resolved
@msub2 msub2 merged commit 8b94260 into main May 10, 2024
1 check passed
@msub2 msub2 deleted the ad-refresh branch May 10, 2024 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants