chore: use v21 as upgrade base #3063
Conversation
gartnera
added
UPGRADE_TESTS
📝 WalkthroughWalkthroughThe changes in this pull request involve updates to the Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
gartnera
requested review from
brewmaster012,
kingpinXD,
lumtis,
ws4charlie,
skosito,
swift1337 and
fbac
as code owners
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
e2e/e2etests/test_eth_withdraw.go (1)
42-43: LGTM with minor suggestions for improvement.
The removal of the IsRunningUpgrade() conditional check simplifies the logic and ensures consistent receipt type verification. Consider these enhancements:
- Extract the expected receipt type to a package-level constant for better maintainability
- Enhance the error message to include actual vs expected values
Apply this diff to implement the suggestions:
+const (
+ // ExpectedWithdrawalReceiptType is the expected receipt type for withdrawals
+ ExpectedWithdrawalReceiptType = ethtypes.DynamicFeeTxType
+)
withdrawalReceipt := mustFetchEthReceipt(r, cctx)
-require.Equal(r, uint8(ethtypes.DynamicFeeTxType), withdrawalReceipt.Type, "receipt type mismatch")
+require.Equal(r, uint8(ExpectedWithdrawalReceiptType), withdrawalReceipt.Type,
+ "withdrawal receipt type mismatch: expected %d, got %d",
+ ExpectedWithdrawalReceiptType, withdrawalReceipt.Type)📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
📒 Files selected for processing (2)
- Makefile (2 hunks)
- e2e/e2etests/test_eth_withdraw.go (1 hunks)
🧰 Additional context used
📓 Path-based instructions (1)
e2e/e2etests/test_eth_withdraw.go (1)
Pattern **/*.go: Review the Go code, point out issues relative to principles of clean code, expressiveness, and performance.
🔇 Additional comments (1)
Makefile (1)
304-304: Verify v21 version references exist
The changes look correct for upgrading the base version. However, let's verify that the referenced version artifacts exist.
Also applies to: 313-313
✅ Verification successful
Version references verified successfully
Both the release branch release/v21 and the release tag v21.0.0 exist in the repository, confirming that the Makefile changes are referencing valid version artifacts.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Description: Verify that both the release branch and binary release exist
# Test 1: Check if release/v21 branch exists
echo "Checking release/v21 branch..."
git ls-remote --heads origin release/v21
# Test 2: Check if v21.0.0 release exists
echo "Checking v21.0.0 release..."
gh release view v21.0.0 --json name,tagName,url
Length of output: 395
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Also remove old usages of
IsRunningUpgrade()in the e2e tests.Summary by CodeRabbit
New Features
zetanodecomponent to version 21, enhancing the upgrade process for users.Bug Fixes
TestEtherWithdrawfunctionality by ensuring the transaction receipt type is verified during upgrades, enhancing test reliability.