Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Event and location titles can be too long in UI #1438

Closed
richardolsson opened this issue Jun 4, 2023 · 0 comments · Fixed by #1516
Closed

Event and location titles can be too long in UI #1438

richardolsson opened this issue Jun 4, 2023 · 0 comments · Fixed by #1516
Assignees
Labels
🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue.

Comments

@richardolsson
Copy link
Member

richardolsson commented Jun 4, 2023

Description

It's currently possible to enter very long event and location titles, and have them render in the CalendarDayView in a way that breaks the UI.

Steps to reproduce

  1. Go to http://localhost:3000/organize/1/projects/1
  2. Click "Create activity"
  3. Click on "Create event"
  4. In the new event, click the title to edit it
  5. Enter a very long (maybe 300 characters) title
  6. Click the location to pick a new one
  7. Create a new location with a very long title and pick that one
  8. Go to the calendar day view on the day of that event

Expected Behaviour

Title should be truncated to single line

Actual Behaviour

Title renders in full, breaking the layout

Screenshots (if you have any)

image

Proposed solutions

It can be argued that it should not be possible to even enter such long titles, and while there is a limit in the API, it's very big (I think 300 characters or 3000 characters). But even if you decide to add some max length to the title field in the UI, the day view still needs to handle long titles.

@richardolsson richardolsson added 🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue. labels Jun 4, 2023
@alexandrakoch alexandrakoch self-assigned this Sep 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐜 bug Something isn't working 🚪 entry-level Good for newcomers 🐬 Medium Just a nice sized issue.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants