Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Truncate title and location in day view #1516

Merged
merged 3 commits into from
Sep 11, 2023

Conversation

alexandrakoch
Copy link
Collaborator

Description

This PR changes the day view for events to truncate the titles and locations to a more reasonable length.

Screenshots

Skärmbild som visar förändringen

Changes

  • Truncate event titles to a maximum length of 50 characters in day view
  • Truncate location names to a maximum length of 40 characters in day view
  • Add noWrap to the event title

Related issues

Resolves #1438

@kaulfield23
Copy link
Contributor

kaulfield23 commented Sep 11, 2023

Nice! I tested it and it works well! I like adding noWrap to event title. I'm thinking it could be also good to add it to location's title. So the day view's height doesn't need to be changed when location's name is long also. What do you think?

@alexandrakoch
Copy link
Collaborator Author

The test location was a single word which doesn't wrap so I assumed the location field inherited it from somewhere else, I'll make a commit to add the nowrap!

Copy link
Contributor

@kaulfield23 kaulfield23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! thanks for the change! it works good 👍

@kaulfield23 kaulfield23 merged commit a54ebc2 into zetkin:main Sep 11, 2023
4 checks passed
@alexandrakoch alexandrakoch deleted the issue-1438/titles-too-long branch September 11, 2023 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Event and location titles can be too long in UI
2 participants