Issue 1472/ellipsis menu icon and text row #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @oskar-christensson! Nice work on this. I'm sorry you didn't hear back already, but this looks like great work and we will review more thoroughly asap! 🙌 |
niklasva82
approved these changes
Sep 6, 2023
niklasva82
approved these changes
Sep 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR solves the bug where the icon and text of the ellipsis menu are not aligned on a single row.
Screenshots
Before:
After:
Changes
[Add a list of features added/changed, bugs fixed etc]
Notes to reviewer
As this is my first pr to this project I would like to emphasize that I am not a front-end develop as I professionally keep to the back-end. However, I thought that this might be something I could enjoy and help with as it is leagues off from what I do during the day.
With that in mind, do not hesitate to call out anything that I should look at more or perhaps avoid doing - I am both new to this stack and this context.
Best regards
Related issues
Resolves #1472