Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 1423/autocomplete resize #1543

Merged
merged 6 commits into from
Sep 29, 2023
Merged

Conversation

kaulfield23
Copy link
Contributor

Description

This PR implements dynamic changing width of EventTypeAutocomplete so that it can show the entire event type text when user types inside of the text field. The text field will be stretched just as same size as input text.

Screenshots

Mozilla.Firefox.2023-09-19.15-12-57.mp4

Changes

  • Adds useEffect to fetch value after onBlur
  • Adds useEffect for resizing autocomplete
  • Adds span
  • Changes messages.type.uncategorized() to text in value property

Notes to reviewer

Related issues

Resolves #1423

@rebecarubio rebecarubio self-assigned this Sep 21, 2023
Copy link
Contributor

@rebecarubio rebecarubio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works super smooth and good! 🚀

@rebecarubio rebecarubio merged commit 16d0337 into main Sep 29, 2023
4 checks passed
@rebecarubio rebecarubio deleted the issue-1423/autocomplete-resize branch September 29, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EventTypeAutocomplete does not resize dynamically
2 participants