Issue 1542/refactor tags hook #1558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rebecarubio
reviewed
Sep 27, 2023
There was a problem hiding this comment.
Nice fix! This lgtm but I would like @richardolsson to double check, as we are getting familiar with this new pattern :)
richardolsson
requested changes
Sep 27, 2023
src/features/tags/hooks/useTag.ts
Outdated
Comment on lines
12
to
14
| tagData: ZetkinTag | null; | ||
| tagError: unknown | null; | ||
| tagIsLoading: boolean; |
There was a problem hiding this comment.
The name of the hook already tells us that the hook will return a tag, so there is no need for these prefixes. I would call these properties:
Suggested change
| tagData: ZetkinTag | null; | |
| tagError: unknown | null; | |
| tagIsLoading: boolean; | |
| data: ZetkinTag | null; | |
| error: unknown | null; | |
| isLoading: boolean; |
src/features/tags/hooks/useTag.ts
Outdated
| ); | ||
| store.dispatch(tagAssigned([personId, tag])); | ||
| }; | ||
| const getTag = () => { |
There was a problem hiding this comment.
This function is unnecessary. Inline it's contents inside the hook instead. You can just grab the return value from loadItemIfNecessary and use that further down the function where you are currently calling getTag().
src/features/tags/hooks/useTag.ts
Outdated
Comment on lines
10
to
11
| assignToPerson: (personId: number, value?: string) => void; | ||
| removeFromPerson: (personId: number) => Promise<void>; |
There was a problem hiding this comment.
I like how these mutation functions are returned.
rebecarubio
merged commit fcf7956
into
issue-1542/refactor-to-use-hooks
4 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR refactors the
tagModelintouseTaghook.Screenshots
Changes
useTagand fix its relevant codesuseTagMutationand fix its relevant codestagModel.tsNotes to reviewer
Didn't delete
tagReposinceassignTagToPersonandremoveTagFromPersonare used inViewDataModel.tsBecause I noticed that
assignTagToPersonandremoveTagFromPersonare used in other places, I decided to make auseTagMutationhook instead of put those methods inuseTag.This will be useful in the future, once
tagRepois removed, as you'll be able to useuseTagMutationto other hooks.Related issues
part of issue-1542