Upgrade Next to version 14

[henrycatalinismith]

This PR upgrades from Next v12 to Next v13v14. The general idea here is to take this a little bit slowly and break it up into very clearly differentiated steps. Ideally this PR will closely follow the official v13 upgrade instructions because nothing will go wrong that takes us outside that happy path.

To get this started, I'm just pushing a plain package.json & yarn.lock update because I think it'll be fun to surface any immediate build errors in public.

[henrycatalinismith]

So that very naive version bump commit gave the following error.

I asked Copilot what could be causing that, and it said:

The error message "TypeError: Cannot read properties of undefined (reading '0')" typically means that you're trying to access an element of an array or object that doesn't exist. In this case, it seems like the nextBuild function is expecting an array as an argument, but it's not getting what it expects.

In Next.js v13, the nextBuild function from next/dist/cli/next-build has been removed or changed, which is likely causing this issue.

You should use the next build command directly in your CI/CD pipeline instead of importing it from next/dist/cli/next-build.

The code in the follow-up commit is more or less Copilot's suggestion except with its usual silly mistakes corrected. It seems to have progressed the build to the next error, so a successful first step.

[henrycatalinismith]

The next error's NextRouter was not mounted, which occurs like 100+ times during the unit tests. I've quickly tried replacing all the useRouter imports with next/compat/router but that's just returning null for the unit tests and so all the same tests are failing except with a different error message. Calling it a night there, good start!

[richardolsson]

The one remaining issue I can see now when looking around the pages is that there have been some sort of changes to links. The MUI links now render in blue, and errors are thrown in some places because the Nextjs Link component no longer likes to have a elements as children. So I will take on that work and fix it everywhere.

In the meantime @henrycatalinismith, maybe you can start playing with merging the work from this branch with the survey work, and begin moving the public survey page over to the app router?

[henrycatalinismith]

git checkout issue-1718/next-v13-upgrade
git rebase main
git push -f origin issue-1718/next-v13-upgrade

[henrycatalinismith]

Here's a sped-up screen recording showing a random series of interactions throughout the admin interface after running rm -rf .next node_modules; yarn; yarn devserver in this branch. Green build and nothing jumping out as obviously broken during exploratory testing, so it's over to you now @richardolsson! See what you think!

14.mov

[richardolsson]

Nice work! I will look more closely into this after we release some stuff that's in the pipeline.

[richardolsson]

We have recently merged the new importer (huge PR #1599). Can you try merging main into this now and make sure this still works @henrycatalinismith?

[richardolsson]

I've looked at this more closely and I think it looks fine. I'd like us to merge #1793 into this first though, so that we can get a preview live and have more people play around with it before we merge. Will request review there!

[richardolsson]

Public link for Vercel deployment: https://app-zetkin-org-git-issue-1718-next-v13-upgrade-zetkin.vercel.app?_vercel_share=G8GmbHFJC4sCBM5FLmEra96mb7ru08Kg

[ziggabyte]

Super nice to have the upgrade!! I have clicked around and did not experience anything strange, so it's a yes for me! :D

[richardolsson]

I have reviewed all the code, and also looked around the deployed preview, and I agree that it all looks good. Let's merge!