Convert ZetkinBlocks to editorJsBlocks to make DeliveryErrors handle properly

[a-jaxell]

Description

When investigating #2263 I found that content blocks in deliveryProblems.ts was passed to
blockProblems.ts without being converted to match the proper data type used.

This resulted in blockProblems() returning an empty array because it could not find any type properties when
kind properties were actually present.

Screenshots

blockbug.mov

Changes

• Adds a conversion of blocks in deliveryProblems.ts

Notes to reviewer

Set as draft until tests are passing locally

My tests are failing locally atm, and I am not sure why at the moment.
When logging output in the test blockProblems() returns an empty array.

1. Go to http://localhost:3000/organize/1/projects/35/emails
2. Create edit any email
3. Add a button
4. Click Delivery - Content Error should be displayed
5. Fill in text and link on button
6. Click Delivery - Content Error should not be displayed

Related issues

Resolves #2263

[richardolsson]

Well spotted @a-jaxell! As you've seen, the tests are failing. In the future, I would recommend using TDD for issues like these, where there are simple tests.

When you find a bug like this, you would first create a test that reproduces it, and then write a fix for that test. In most cases, arriving at a functional fix will be faster, and once you consider that by the time you're done you already have a test written, the time saved will be even bigger.

[a-jaxell]

Thanks for the input, I'll give it a go as soon as I'm able. 🙂

[ziggabyte]

Some investigation led me to see that when I created the tests for this function and written them, I'd mistaken the datatypes and written tests with data in the wrong shape. Have updated the test now!
The problem you discovered with the wrong type of the data that was parsed from JSON was the key to the mystery @a-jaxell !