Add missing type annotations & catch unhandled exceptions

[MarkusPettersson98]

Description

This PR is just some minor code cleanups and bug fixes 🐞 🧹

Bug fixes

I found a lot of code on the following form

const apiClient = new BackendApiClient(ctx.req.headers);
const data = await apiClient.get<T>('api/getData');
if(data) {
  return { .. };
} else {
  return {
    notFound: true
  };
}

The problem with this is that we can't expect T to be a falsy value if apiClient.get is able to fetch the value. T will in practice be some kind of object, and as such the if-body will always be hit.

If get would fail to fetch the value, it will instead throw an exception. As such, the correct form would be

try {
  const apiClient = new BackendApiClient(ctx.req.headers);
  const data = await apiClient.get<T>('api/getData');
  return { .. };
} catch {
  return { 
    notFound: true
  };
}

This would correctly return { notFound: true } if data could not be fetched.

Since data is seldom used, it can often be elided and we simply execute apiClient.get<T>('api/getData') for the side effect of maybe triggering the exception.

Cleanups

Add type annotations to some of the aforementioned get-requests where they were missing. Nothing fancy

Changes

• Catch a bunch of unhandled exceptions.
• Properly redirect in case above exceptions are found (based on how the code looked when I started working on it)
• Add type annotations to some get-requests.

Notes to reviewer

Unfortunately, this is a rather boring PR to review. I guess you could try to browse all affetched pages and try to fetch invalid data. Otherwise, it is a matter of reviewing this rather mechanical code transformation by hand.

[richardolsson]

I'm very happy that you and your critical eyes are part of this project! I think this PR contributes several improvements, but there are also some things that I believe could be improved further. Please see comments below.

[richardolsson]

Actually, I don't think we need to make this request. The API request above (for the journey instance) will fail if the user cannot access it, and if it can access the journey instance it will also be able to access the organization.

[richardolsson]

This comment refers to "the returned organization", which I believe is a copy-paste error. Personally, I would remove the comment. I usually prefer to avoid comments (because they can become misleading over time if not carefully kept up to date) but I admit this is a grey area.

[richardolsson]

This request should not be necessary.

[richardolsson]

This request should not be necessary.