Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set list of places as "stale" when running "sync" function. #2419

Merged
merged 2 commits into from
Dec 9, 2024

Conversation

ziggabyte
Copy link
Contributor

Description

This PR sets the list of places to stale when clicking the button to "sync" stats and data in the canvasser interface.

Screenshots

none

Changes

  • Adds store reducer that sets list of places to stale

Notes to reviewer

I did not figure out how to test this in action, so it's just wild and crazy like that but i'm thinking the logic should work?

Related issues

none

Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried the preview build, where I clicked the button while looking at the Redux dev tools and in the network panel. The action is not being dispatched correctly, and no network request is made to load places. I believe the problem is below.

src/features/canvassAssignments/hooks/useSidebarStats.ts Outdated Show resolved Hide resolved
Co-authored-by: Richard Olsson <r@richardolsson.se>
Copy link
Member

@richardolsson richardolsson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this works as expected now! Lets merge (if tests pass). 💯

@ziggabyte ziggabyte merged commit 9f69df8 into main Dec 9, 2024
6 checks passed
@ziggabyte ziggabyte deleted the undocumented/load-places-on-sync branch December 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants