Initial support for std::string_view #633
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on work from @brandl-muc
Initial PR for supporting std::string_view as laid out in #626
For CI config, the new define was added to the matrix testing configuration. The new code is only exercised when using c++17 std lib or later, so an additional build & run was added to all platforms. After the code settles, the expectation is for PUGIXML_STRING_VIEW to be retired, which will help reduce CI run bloat.
Appveyor configs are not updated as part of this change. The appveyor runs are determined to be slow, the majority of new runs created by adding this to the matrix would be redundant due to most of the matrix not having c++17, and we will gain coverage automatically when the opt-in define is retired.
This change causes a new internal define
PUGIXML_HAS_STRING_VIEW
to be conditionally defined by the header, and it is never undefined.