Makefile now defaults to cxxstd=any #639
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This means that by default we inherit the default language version supported by the compiler; this will help with string_view testing in the future as it will "just work" out of the box once the define is set. This should also automatically enable CI coverage for string_view; C++11 is still explicitly tested in CI via cxxstd=c++11.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This means that by default we inherit the default language version supported by the compiler; this will help with string_view testing in the future as it will "just work" out of the box once the define is set.
This should also automatically enable CI coverage for string_view; C++11 is still explicitly tested in CI via cxxstd=c++11.
Related: #626