Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: maven build #131

Merged
merged 23 commits into from
Dec 2, 2022
Merged

chore: maven build #131

merged 23 commits into from
Dec 2, 2022

Conversation

frisonisland
Copy link
Contributor

This is the new PR for maven build changes. Reason is old branch had files moved around and they lost history.
Another benefit is that here there are fewer commits, so it may be easier for you to see the changes.
Unfortunately lot of them address test resources, because I still had some troubles with files line separator, etc.

Goal

Moving the project to maven.
This will allow us to fix many dependencies issue we have, and also be able to add new features more easily with all the tools we need (e.g.: TestContainers, etc.)

Memorable changes

  • soap-doc module has been removed and the code is now inside soap
  • store module is a WAR
  • dependency management declared in parent zm-mailbox pom
  • store compiles twice: pre-compile, generate-sources, compile again
  • carbonio.buildinfo.version statically declared in ant-build-common.xml

Copy link
Contributor

@Polpetta Polpetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've reviewed everything 🌚 , of course LGTM

Copy link
Member

@keshavbhatt keshavbhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frisonisland frisonisland merged commit c986a28 into devel Dec 2, 2022
@frisonisland frisonisland deleted the chore/maven-build branch December 2, 2022 08:11
frisonisland added a commit that referenced this pull request Dec 15, 2022
* chore: add release-it (#121)

* chore: add release-it and update README.md

* chore: add CHANGELOG.md

* chore(Jenkinsfile): release-it integration

* chore(Jenkinsfile): add devel repository (#122)

* fix:[CO-440] properly de-register authToken (#119)

- properly remove account AuthToken to invalidate the session cookie
in Soap EndSession

* fix: zimbraReverseProxyDnsLookupInServerEnabled false (#118)

* fix: zimbraReverseProxyDnsLookupInServerEnabled false
* chore(pre-commit): exclude attrs.xml from lint
*chore(attrs.xml): re-apply changes
* chore(attrs.xml): improve zimbraReverseProxyDnsLookupInServerEnabled description

* fix:[CO-457] delete orphaned cert-key pair from domain SSL dir (#126)

* fix: delete orphaned certificate key
pair from domain cert dir

* chore: remove temp null checks

* chore: show in logs if obsolete cert key file is not deletable

* fix(generate-rights): use custom localconfig (#129)

* feat: [CO-459] add new white-label management attributes (#128)

* feat: add primary color attributes for domain entries

* chore: add attribute for Web Ui banner text

* feat: run generate-getters in store

* feat: run generate-rights in store

* feat(attrs.xml): zimbraClamAVDatabaseMirror multiAttr (#130)

* feat(attrs.xml): zimbraClamAVDatabaseMirror multiAttr

* chore: change default clamAV db + description

* chore: generate-getters

* refactor: maven build (#131)

* refactor: move java -> main/java, java-test -> test/java

* refactor: import pom changes from feature/maven-build branch

* chore: adapt Jenkinsfile

* refactor: remove ant and ivy build files

* chore: store + store-conf maven

* chore: minor changes

* chore(zm-native): native dir in main/native

* refactor: move soap-docs classes in soap module

* refactor: store db/hsqldb -> main/db/hsqldb
* refactor: com.zimbra.qa -> test/java/qa
* refactor:  AccountTestUtil moved from qa to src/main/com.zimbra.cs.service.admin

* refactor: store db/hsqldb -> main/db/hsqldb
* chore: DbTag non-final
* refactor: DbTag verify methods to DbTagTestUtil (extends DbTag)
* refactor: TagTest, AuthTest, TestTnefTimezone, RunUnitTests to test classes

* refactor: move test resources location
* refactor: MailboxTestUtil resources location
* refactor: HSQLDB resources location

* refactor: fix hsqldb resources location

* fix: test resources location ref

* fix: test resources crlf

* fix: MimeTest carriage return

* fix: MimeTest

* fix: ignore MimeTest migration info

* chore: MimeTest bug95114 files content

* chore: MimeTest bug95114 files content (2)

* chore: MimeTest CRLF

* chore: snapshot on chore/maven-build

* chore: 23.1.0-SNAPSHOT

* chore: distribution management release repository

* feat: [CO-467] add carbonioCalAVDatabaseCustomURL global multi-attr (#132)

* feat:[CO-475] add carbonio features attributes (#133)

* feat: add attribute definitions

* chore: generate java code and rights definition

Co-authored-by: Keshav Bhatt <keshavnrj@gmail.com>
Co-authored-by: Keshav Bhatt <keshavbhatt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants