Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: [CO-603] remove deprecated attributes #217

Merged
merged 13 commits into from
May 10, 2023
Merged

Conversation

frisonisland
Copy link
Contributor

@frisonisland frisonisland commented May 9, 2023

Goal

Main goal is removing deprecated attributes.
Since many attributes are still used in some features, also features that are not needed anymore have been removed.

Removed features

Aside attributes, these are removed features:

  • Wiki
  • MigrateAccount (API)
  • LdapUpgrade mechanism (bugs)
  • Child Account (old feature)
  • isParentOf logic for child account (ACL)
  • remove RunUnitTests API
  • remove most of QA unittests classes (except 2, MessageBuilder and TestUtil)

Other deprecated attributes

These are additional non-requested attributes that I removed because deprecated:

  • "735" name="zimbraReverseProxyInactivityTimeout"
  • "847" name="zimbraMobilePolicyDeviceEncryptionEnabled"
  • "1070" name="zimbraDomainMandatoryMailSignatureText"
  • "1071" name="zimbraDomainMandatoryMailSignatureHTML"
  • "1208" name="zimbraMailEmptyFolderBatchThreshold"
  • "1378" name="zimbraReverseProxyUpstreamServers"
  • "1538" name="zimbraMtaStpdSoftErrorLimit"

frisonisland and others added 11 commits April 13, 2023 17:43
* removes also wiki migration in mailbox startup
* LdapUpgrade removed as it was used to migrate bugs
* remove Imap remote port usage
* remove MTA auth url from URLUtil
* remove child account/parentOf logic in ACL
* remove zimbraNotebook from rights xml files
- remove zimbraMobilePolicyDeviceEncryptionEnabled from rights
- remove unit tests API
- remove many qa unittests (not used)
- remove unused methods in TestUtil
* chore: remove Mailbox auto-update logic

* chore: remove MailboxUpgrade.java (unused)
Copy link
Contributor

@Polpetta Polpetta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, I trust you on this one

Copy link
Member

@keshavbhatt keshavbhatt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust you 🤝

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants