feat: [CO-675] Let admin set arbitrary PublicService & Virtual hostname #220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
store/src/main/java/com/zimbra/cs/service/admin/ModifyDomain.java
Outdated
Show resolved
Hide resolved
|
Please limit the length of the title of this PR. :D |
frisonisland
requested changes
May 12, 2023
store/src/test/java/com/zimbra/cs/service/admin/ModifyDomainIT.java
Outdated
Show resolved
Hide resolved
store/src/test/java/com/zimbra/cs/service/admin/ModifyDomainIT.java
Outdated
Show resolved
Hide resolved
store/src/test/java/com/zimbra/cs/service/admin/ModifyDomainIT.java
Outdated
Show resolved
Hide resolved
aheeva-yuliya
changed the title
keshavbhatt
changed the title
aheeva-yuliya
force-pushed
the
feat_CO-675_allow_global_admin_md
branch
from
f80fa5c to
0bd974b
Compare
Polpetta
approved these changes
May 15, 2023
|
LGTM after @frisonisland's suggestions |
frisonisland
approved these changes
May 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now global admin and delegated admin with granted right
modifyGlobalConfigcould set an arbitrary value for zimbraPublicServiceHostname and zimbraVirtualHostname.