Revert "refactor: remove mailboxd_directory (#549)" #554
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7dcd419.
frisonisland
requested review from
sonersivri,
keshavbhatt,
aheeva-yuliya,
mbarto and
giuliano176
and removed request for
a team
keshavbhatt
approved these changes
Jul 17, 2024
|
Analysis Details14 Issues
Coverage and Duplications
Project ID: zextras:zm-mailbox |
|
Analysis Details14 Issues
Coverage and Duplications
Project ID: zextras:zm-mailbox |
aheeva-yuliya
approved these changes
Jul 18, 2024
sonersivri
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 7dcd419.
We found out that actually mailboxd directory still exists, and it is a symbolic link to /opt/zextras/jetty_base, which is created by the package carbonio-appserver.
We plan to further clean it up in the future as there are still many references to it and in carbonio-bootstrap logic.