Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: [CO-1441][CO-1443] rewrite handlers #572

Merged
merged 2 commits into from
Aug 30, 2024
Merged

fix: [CO-1441][CO-1443] rewrite handlers #572

merged 2 commits into from
Aug 30, 2024

Conversation

frisonisland
Copy link
Contributor

@frisonisland frisonisland commented Aug 30, 2024

This PR fixes the rewrite and access log bugs.

Handlers have been re-arranged to be:

  • RewriteHandler
    • defaulthandler
    • webApp
    • requestlog

In case of compression enabled it's the same, except gziphandler is on top of the chain

So rewrites are applied before everything

- handlers have been re-arranged to be:
 - RewriteHandler
   - defaulthandler
   - webApp
   - requestlog

In case of compression enabled it's the same, except gziphandler is on top of the chain

So rewrites are applied before everything
@frisonisland frisonisland requested a review from a team as a code owner August 30, 2024 08:04
- reintroduce access log
@frisonisland frisonisland changed the title fix: [CO-1441] rewrite handlers fix: [CO-1441][CO-1443] rewrite handlers Aug 30, 2024

This comment has been minimized.

Copy link

Failed

  • 2 New Issues (is greater than 0)

Analysis Details

2 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 2 Code Smells

Coverage and Duplications

  • Coverage 100.00% Coverage (28.40% Estimated after merge)
  • Duplications 0.00% Duplicated Code (2.90% Estimated after merge)

Project ID: zextras:zm-mailbox

View in SonarQube

@frisonisland frisonisland merged commit 1d4af75 into main Aug 30, 2024
2 of 3 checks passed
@frisonisland frisonisland deleted the fix/CO-1441 branch August 30, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants