fix: versioning #577
Merged
fix: versioning #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- avoid using two different buildingTag methods as it can lead to inconsistency
- according to Jenkins doc, TAG_NAME environment variables is set only when building tag
frisonisland
requested review from
keshavbhatt,
drazen04 and
zextrasGiovanniDefacci
and removed request for
a team
aheeva-yuliya
approved these changes
Sep 3, 2024
zextrasGiovanniDefacci
approved these changes
Sep 3, 2024
sonersivri
approved these changes
Sep 3, 2024
sonersivri
reviewed
Sep 3, 2024
sonersivri
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes address three issues:
We noticed that releasing a non SNAPSHOT version produces a pom with SNAPSHOT dependencies, for example zm-mailbox-24.9.1.pom contains zm-common-24.9.1-SNAPSHOT.
This causes projects using mailbox as dependency will fail downloading transitive dependencies (zm-store-24.9.1-SNAPSHOT does not exist).
Using ${project.version} seems to be the supported way by Maven.