fix: data persist on mails editor #126
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nubsthead
requested review from
zovomat,
geeky-abhishek,
giuliano176,
dhavaldodiya,
FrancescoGottardi and
gnekoz
as code owners
dhavaldodiya
approved these changes
Jul 14, 2022
giuliano176
approved these changes
Jul 15, 2022
geeky-abhishek
approved these changes
Jul 15, 2022
| ) { | ||
| if (!editors[editorId] || actionChanged) { | ||
| if (!editors[editorId] || isSameAction === false) { |
There was a problem hiding this comment.
!isSameAction and in the memo why don't we return default as false instead of undefined ?
There was a problem hiding this comment.
If we start false as default it means every time we change module and come back it will trigger a new editor creation causing the opening of a new editor which is not the desiderata. We want to persist the editor values when we change module and this was the safest way
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.