feat: open EML attachments in a new tab #310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chore: overlay parent
chore: removed react-new-window from dependencies
feat: enable giving focus from an extra window to other opened extra windows feat: add function to the ExtraWindowManager to get the focused extra window feat: show a modal message when browser blocks the window opening
feat: enable giving focus from an extra window to other opened extra windows feat: add function to the ExtraWindowManager to get the focused extra window feat: show a modal message when browser blocks the window opening
refactor: code splitting feat: nested PDF attachment preview fallback
… window's documents
chore: set the target window in the attachments download link
chore: updated attachment preview tooltip description
giuliano176
previously approved these changes
Feb 28, 2023
| @@ -372,6 +372,8 @@ const EditView: FC<EditViewPropType> = ({ setHeader }) => { | |||
| [action, editor?.attach?.mp?.length, editor?.original] | |||
| ); | |||
|
|
|||
| // const showAttachments = true; | |||
There was a problem hiding this comment.
this sneaky comment made it to the pr :)
| const extension = getFileExtension(att).value; | ||
| const theme = useTheme(); | ||
| // const isInsideExtraWindow = false; |
| icon={tagIcon} | ||
| onClick={onIconClick} | ||
| // color={`${tagIconColor}`} | ||
| /> |
chore: code cleanup
giuliano176
approved these changes
Feb 28, 2023
nubsthead
approved these changes
Feb 28, 2023
giuliano176
added a commit
that referenced
this pull request
Mar 16, 2023
f8498690 Translated using Weblate (Spanish) e6d637b0 Translated using Weblate (Polish) 19c12c07 Translated using Weblate (Chinese (Simplified)) 361f94e2 Translated using Weblate (Turkish) a4d5fa7e Translated using Weblate (Thai) 7890561c Translated using Weblate (Portuguese (Brazil)) 2fecd900 Translated using Weblate (Dutch) 0730550f Translated using Weblate (Japanese) 2cb0ce21 Translated using Weblate (Indonesian) 218eae52 Translated using Weblate (Hindi) aed180e0 Translated using Weblate (Spanish) 5a1e0937 Translated using Weblate (German) b1242505 Translated using Weblate (French) c978baf2 Translated using Weblate (Russian) 7cc5ab1d Translated using Weblate (Italian) 06664873 Translated using Weblate (English) d54646d1 Update translation files 62cb1658 Translated using Weblate (Spanish) 44ca5bee Translated using Weblate (French) 86436a6a Merged in 20230302-rc (pull request #78) e7e226e7 Merge commit 'ad4f77f2b291bbc83018598b2394042f18c85757' into 20230302-rc 4a806553 feat: open EML attachments in a new tab (#310) 775a4872 fix: status label change in advance search ec7def7f feat: updating files integration 7ea9b90e Iris 3255 select all (#313) f136f462 feat: setting signatures for identities (#299) e68674d6 chore: merge version bumper into devel 933d5c0d fix: default identity selection where replying 09897dd3 Version bumper/v1.1.0 1 (#301) d10ae5bf Merge commit 'dbe4da31015d5cb41a6d6004ca621d5e4b776568' into 20230202-rc fb940aad Merge branch 'devel' into version-bumper/v1.0.0-1 e21b2faf feat: added download section to preview-eml (#291) git-subtree-dir: translations git-subtree-split: f84986906f8d4b5590521aa70f13bf2500d37e34
gnekoz
added a commit
that referenced
this pull request
Mar 30, 2023
01187c1b Translated using Weblate (Spanish) ef5571f2 Translated using Weblate (Vietnamese) 9c95c277 Translated using Weblate (Portuguese) fc373f34 Translated using Weblate (Vietnamese) 5526a189 Translated using Weblate (Polish) 21d8b283 Translated using Weblate (Chinese (Simplified)) a1a50fd1 Translated using Weblate (Thai) 44c4109c Translated using Weblate (Portuguese (Brazil)) 4faf5eed Translated using Weblate (Dutch) e901fbfd Translated using Weblate (Japanese) dc829870 Translated using Weblate (Indonesian) 3a713f59 Translated using Weblate (Hindi) 59d2309b Translated using Weblate (Spanish) 630e5878 Translated using Weblate (Spanish) aee14a5a Translated using Weblate (German) 0792d5a4 Translated using Weblate (French) 15c19145 Translated using Weblate (Russian) 10d1d820 Translated using Weblate (Italian) 97553194 Translated using Weblate (English) ea0fb7f6 Translated using Weblate (Spanish) f8498690 Translated using Weblate (Spanish) e6d637b0 Translated using Weblate (Polish) 19c12c07 Translated using Weblate (Chinese (Simplified)) 361f94e2 Translated using Weblate (Turkish) a4d5fa7e Translated using Weblate (Thai) 7890561c Translated using Weblate (Portuguese (Brazil)) 2fecd900 Translated using Weblate (Dutch) 0730550f Translated using Weblate (Japanese) 2cb0ce21 Translated using Weblate (Indonesian) 218eae52 Translated using Weblate (Hindi) aed180e0 Translated using Weblate (Spanish) 5a1e0937 Translated using Weblate (German) b1242505 Translated using Weblate (French) c978baf2 Translated using Weblate (Russian) 7cc5ab1d Translated using Weblate (Italian) 06664873 Translated using Weblate (English) d54646d1 Update translation files 62cb1658 Translated using Weblate (Spanish) 44ca5bee Translated using Weblate (French) 86436a6a Merged in 20230302-rc (pull request #78) e7e226e7 Merge commit 'ad4f77f2b291bbc83018598b2394042f18c85757' into 20230302-rc 4a806553 feat: open EML attachments in a new tab (#310) 775a4872 fix: status label change in advance search ec7def7f feat: updating files integration 934ea26f Translated using Weblate (French) 7ea9b90e Iris 3255 select all (#313) f136f462 feat: setting signatures for identities (#299) 5323700f Translated using Weblate (Thai) f3133fd3 Translated using Weblate (Dutch) e68674d6 chore: merge version bumper into devel 933d5c0d fix: default identity selection where replying 2e62c613 Translated using Weblate (Polish) 5028ca57 Translated using Weblate (Chinese (Simplified)) 2cc98b54 Translated using Weblate (Portuguese (Brazil)) d209dc73 Translated using Weblate (Indonesian) 7fd4a41f Translated using Weblate (Spanish) dc6fc260 Translated using Weblate (Polish) 040c03f9 Translated using Weblate (Thai) 4bf014b5 Translated using Weblate (Dutch) e7971a1d Translated using Weblate (Japanese) a95d5f4e Translated using Weblate (Indonesian) 8c6fc1be Translated using Weblate (Hindi) 25e32a4e Translated using Weblate (Hindi) d0d33fdb Translated using Weblate (Italian) 47d39966 Translated using Weblate (Japanese) 33ceb701 Translated using Weblate (Japanese) 09897dd3 Version bumper/v1.1.0 1 (#301) d10ae5bf Merge commit 'dbe4da31015d5cb41a6d6004ca621d5e4b776568' into 20230202-rc fb940aad Merge branch 'devel' into version-bumper/v1.0.0-1 e21b2faf feat: added download section to preview-eml (#291) git-subtree-dir: translations git-subtree-split: 01187c1bea8b3cb1f638e8430562dddbe5e05ad3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feat: added an EML viewer which renders in a new tab. Nested EML attachments will be rendered inside new tabs.
NOTE: depends on zextras/carbonio-design-system#171
ref: IRIS-3663