Merge pull request #51 from Zextras/hardcoded-strings

Hardcoded strings
zextras · Mar 28, 2022 · 744ecab · 744ecab
2 parents 93e9a5b + 631e023
commit 744ecab
Show file tree

Hide file tree

Showing 5 changed files with 15 additions and 5 deletions.
diff --git a/src/settings/components/account-settings/external-account-settings.tsx b/src/settings/components/account-settings/external-account-settings.tsx
@@ -58,10 +58,18 @@ const ExternalAccount = ({ t }: ExternalAccountProps): ReactElement => {
 				mainAlignment="flex-start"
 			>
 				<Row width="50%" padding={{ right: 'small' }}>
-					<Input label="Email Address" value="name.surname@company.com" background="gray5" />
+					<Input
+						label={t('label.email_address', 'E-mail address')}
+						value="name.surname@company.com"
+						background="gray5"
+					/>
 				</Row>
 				<Row width="50%">
-					<Input label="Account Name" value="New External Account 1" background="gray5" />
+					<Input
+						label={t('label.account_name', 'Account Name')}
+						value="New External Account 1"
+						background="gray5"
+					/>
 				</Row>
 			</Row>
 			<Row

diff --git a/src/settings/components/account-settings/persona-use-section.tsx b/src/settings/components/account-settings/persona-use-section.tsx
@@ -184,7 +184,7 @@ const PersonaUseSection = ({
 			>
 				<Row width="50%" padding={{ right: 'small' }}>
 					<ChipInput
-						label="e.g. Bob Smith"
+						label={t('label.reply_to_field_example', "e.g. Bob Smith")}
 						value=""
 						placeholder={t('label.folders', 'Folders')}
 						background="gray5"

diff --git a/src/settings/components/general-settings/module-version-settings.tsx b/src/settings/components/general-settings/module-version-settings.tsx
@@ -53,7 +53,7 @@ const ModuleVersionSettings: FC = () => {
 							<Text>
 								{app.display} ({app.name})
 							</Text>
-							<Tooltip placement="top" label="Click to copy">
+							<Tooltip placement="top" label={t('label.click_to_copy', 'Click to copy')}>
 								<Text style={{ cursor: 'pointer' }} onClick={(e: any): any => copyToClipboard(e)}>
 									Version: {app.version}
 								</Text>

diff --git a/src/ui-extras/spinner.tsx b/src/ui-extras/spinner.tsx
@@ -9,6 +9,7 @@ import { Button, Container } from '@zextras/carbonio-design-system';
 
 export const Spinner: FC = () => (
 	<Container width="fill" height="fill" mainAlignment="center" crossAlignment="center">
+		{/* the "Button" string doesn't need to be translated as it's not rendered */}
 		<Button type="ghost" label="Button" color="primary" loading />
 	</Container>
 );
diff --git a/translations/en.json b/translations/en.json
@@ -36,11 +36,13 @@
         "add_recovery_email": "Add recovery e-mail",
         "address": "Address",
         "advanced_settings": "Advanced Settings",
+        "button": "Button",
         "cancel": "Cancel",
         "change_pop": "Change POP port",
         "choose_account": "Choose an account",
         "choose_folder": "Choose Folder",
         "clear_search_query": "CLEAR SEARCH",
+        "click_to_copy": "Click to copy",
         "default_from_name": "Default From Name",
         "delegates": "Delegates",
         "delete": "Delete",
@@ -83,7 +85,6 @@
         "recovery_email": "Recovery Email",
         "reload": "Reload",
         "remove": "remove",
-        "replyToFieldExample": "e.g. Bob Smith",
         "reply_to_field_example": "e.g. Bob Smith",
         "save": "Save",
         "save_and_leave": "Save and leave",