Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show a modal on failure of getInfo and getComponents #251

Merged
merged 17 commits into from
Jun 16, 2023
Merged

fix: show a modal on failure of getInfo and getComponents #251

merged 17 commits into from
Jun 16, 2023

Conversation

CataldoMazzilli
Copy link
Member

@CataldoMazzilli CataldoMazzilli commented May 24, 2023 •
edited
Loading

refs: SHELL-92

@CataldoMazzilli CataldoMazzilli marked this pull request as ready for review May 26, 2023 15:22
@CataldoMazzilli CataldoMazzilli requested review from a team as code owners May 26, 2023 15:22
@CataldoMazzilli CataldoMazzilli changed the title fix: show a modal on failure of getInfo, getComponents and loginConfi… fix: show a modal on failure of getInfo, getComponents May 26, 2023
@CataldoMazzilli CataldoMazzilli changed the title fix: show a modal on failure of getInfo, getComponents fix: show a modal on failure of getInfo and getComponents May 26, 2023
beawar
beawar reviewed May 30, 2023
View reviewed changes
src/boot/bootstrapper-router.tsx Outdated Show resolved Hide resolved
src/boot/bootstrapper-router.tsx Outdated Show resolved Hide resolved
src/boot/bootstrapper-router.tsx Outdated Show resolved Hide resolved
src/boot/bootstrapper-router.tsx Outdated Show resolved Hide resolved
src/boot/loader.test.tsx Outdated Show resolved Hide resolved
src/network/get-info.ts Show resolved Hide resolved
@CataldoMazzilli CataldoMazzilli self-assigned this Jun 7, 2023
@CataldoMazzilli CataldoMazzilli requested a review from beawar June 7, 2023 15:24
beawar
beawar previously approved these changes Jun 12, 2023
View reviewed changes
src/boot/loader.test.tsx Outdated Show resolved Hide resolved
src/boot/loader.test.tsx Outdated Show resolved Hide resolved
src/boot/loader.tsx Outdated Show resolved Hide resolved
@CataldoMazzilli @beawar
Update src/boot/loader.test.tsx
3761be7 
Co-authored-by: Beatrice Guerra <beatrice.guerra@zextras.com>
CataldoMazzilli and others added 3 commits June 15, 2023 12:02
@CataldoMazzilli @beawar
Update src/boot/loader.tsx
dd910e1 
Co-authored-by: Beatrice Guerra <beatrice.guerra@zextras.com>
@CataldoMazzilli @beawar
Update src/boot/loader.test.tsx
3cc672e 
Co-authored-by: Beatrice Guerra <beatrice.guerra@zextras.com>
@CataldoMazzilli
test: apply review hints
4559c4a
@CataldoMazzilli CataldoMazzilli requested review from beawar and removed request for giuliano176, MatteoPerdon and FrancescoGottardi June 15, 2023 10:31
beawar
beawar previously approved these changes Jun 15, 2023
View reviewed changes
nubsthead
nubsthead previously approved these changes Jun 15, 2023
View reviewed changes
src/boot/bootstrapper-provider.tsx Outdated Show resolved Hide resolved
@CataldoMazzilli CataldoMazzilli dismissed stale reviews from nubsthead and beawar via 307cf07 June 15, 2023 13:25
@CataldoMazzilli CataldoMazzilli merged commit 2df0658 into devel Jun 16, 2023
@CataldoMazzilli CataldoMazzilli deleted the SHELL-92-manage-getInfo-failure branch June 16, 2023 07:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beawar beawar beawar approved these changes

@CerDennis CerDennis CerDennis approved these changes

@nubsthead nubsthead nubsthead approved these changes

Assignees

@CataldoMazzilli CataldoMazzilli

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CataldoMazzilli @beawar @CerDennis @nubsthead