Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added Hungarian language #543

Merged
merged 5 commits into from
Nov 14, 2024
Merged

feat: added Hungarian language #543

merged 5 commits into from
Nov 14, 2024

Conversation

FrancescoGottardi
Copy link
Contributor

  • added support for Hungarian language

This comment has been minimized.

Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a feat, not a chore, since it is adding something.

Have you checked date-fns and tinymce locales to see if the key match?

@FrancescoGottardi FrancescoGottardi changed the title chore: added Hungarian language feat: added Hungarian language Nov 13, 2024
@FrancescoGottardi
Copy link
Contributor Author

This is a feat, not a chore, since it is adding something.

Have you checked date-fns and tinymce locales to see if the key match?

This is a feat, not a chore, since it is adding something.

Have you checked date-fns and tinymce locales to see if the key match?

Hi,
i added the one related to the tinymce, the dats fns instead was fine;

This comment has been minimized.

@beawar
Copy link
Contributor

beawar commented Nov 13, 2024

i added the one related to the tinymce

I'm sorry, but this is not the official language pack for the version we are using (v6). See the documentation here https://www.tiny.cloud/docs/tinymce/6/ui-localization/ (the link is present also in the LocaleDescriptor type)

Also, if you try the UI and set the UI language to Hungarian, you can see the composer is not translated. And that's because the language pack is not available.
You need to also add the language file inside the assets/tinymce/langs folder, which is used by the Composer component to retrieve the translations

This comment has been minimized.

This comment has been minimized.

Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage No coverage information (66.50% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: carbonio-shell-ui

View in SonarQube

@beawar beawar merged commit 2ae81aa into devel Nov 14, 2024
3 checks passed
@beawar beawar deleted the CO-1650 branch November 14, 2024 09:37
@beawar
Copy link
Contributor

beawar commented Nov 15, 2024

@Gammax92 @MatteoPerdon Remember to add strings in weblate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants