Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Spinner of Shell with the DS one #174

Merged
merged 7 commits into from
Nov 19, 2024

Conversation

rodleyorosa
Copy link
Contributor

@rodleyorosa rodleyorosa commented Nov 13, 2024

Refs: TSK-97

Spinner of Shell will be removed:
https://zextras.atlassian.net/browse/SHELL-254
zextras/carbonio-shell-ui#544

@rodleyorosa rodleyorosa self-assigned this Nov 13, 2024
@rodleyorosa rodleyorosa requested a review from a team as a code owner November 13, 2024 15:14

This comment has been minimized.

Copy link
Contributor

@beawar beawar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to include also the container, because the spinner is now on the top instead of being vertically centered

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

@CataldoMazzilli
Copy link
Member

can we use the same approach as the other pr?

This comment has been minimized.

Copy link

Passed

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 50.00% Coverage (90.90% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.00% Estimated after merge)

Project ID: carbonio-tasks-ui

View in SonarQube

@rodleyorosa rodleyorosa merged commit 1d70f1b into devel Nov 19, 2024
3 checks passed
@rodleyorosa rodleyorosa deleted the TSK-97-Replace-Spinner-of-Shell-with-the-DS-one branch November 19, 2024 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants