Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace Spinner of Shell with the DS one #430

Merged
merged 4 commits into from
Nov 26, 2024

Conversation

rodleyorosa
Copy link
Contributor

@rodleyorosa rodleyorosa commented Nov 13, 2024

Refs: WSC-1759

Spinner of Shell will be removed:
https://zextras.atlassian.net/browse/SHELL-254
zextras/carbonio-shell-ui#544

@rodleyorosa rodleyorosa self-assigned this Nov 13, 2024
@rodleyorosa rodleyorosa requested a review from a team as a code owner November 13, 2024 16:38

This comment has been minimized.

This comment has been minimized.

CerDennis
CerDennis previously approved these changes Nov 15, 2024

This comment has been minimized.

lisaparma
lisaparma previously approved these changes Nov 18, 2024
@CerDennis CerDennis dismissed stale reviews from lisaparma and themself via 25003c1 November 26, 2024 09:15
Copy link

Failed

  • 50.00% Coverage on New Code (is less than 80.00%)

Analysis Details

0 Issues

  • Bug 0 Bugs
  • Vulnerability 0 Vulnerabilities
  • Code Smell 0 Code Smells

Coverage and Duplications

  • Coverage 50.00% Coverage (83.30% Estimated after merge)
  • Duplications 0.00% Duplicated Code (0.10% Estimated after merge)

Project ID: carbonio-ws-collaboration-ui

View in SonarQube

@CerDennis CerDennis merged commit 791e149 into devel Nov 26, 2024
2 of 3 checks passed
@CerDennis CerDennis deleted the WSC-1759-Replace-Spinner-of-Shell-with-the-DS-one branch November 26, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants