This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
[v2.0] [BC Break] Rewrite library with ConsoleHelper + tests #8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
|
Green! :) Ready for review @weierophinney |
Script is changed to: $ vendor/bin/composer autoloading <command> [options] modulename Commands: - help - display help/usage message - enable - enable composer autoloading for the module - disable - disbale composer autoloading for the module Options are the same as previously: - --help|-h - display help/usage message - --composer|-c - composer binary path; defaults composer - --type|-t - module autoloading type to use - --modules-path|-p - path to directory with modules Added tests for the whole library and added coveralls configuration.
- svg travis build badge pointing master branch - added coverage status badge
Variable $publicDir is now private
Redirect stderr to stdout 2>&1 Works also on Windows.
AbstractCommand now has public method process instead of __invoke. Command have to implement method execute, which is called in process.
This tests mock "system" method so it should be run in separate process.
Run test on PHP 5.6/7.0/7.1 with lowest/locked/latest dependencies.
Tests vere failing on PHP7.0/7.1 with lowest dependencies
Without this annotation these tests on travis are failing. On local I can't observe this issue.
|
@weierophinney rebased |
weierophinney
approved these changes
Feb 22, 2017
| @@ -8,7 +8,7 @@ | |||
| "console", | |||
| "framework", | |||
| "zendframework", | |||
| "zf2" | |||
| "zf3" | |||
There was a problem hiding this comment.
I'd argue we should drop the version-specific tags, and just stick with zendframework.
| { | ||
| $this->path = $path; | ||
| $this->composerJsonFile = sprintf('%s/composer.json', $path); | ||
| $this->command = (string)$command; |
There was a problem hiding this comment.
Should be a space following the ); I thought that was setup in the zend-coding-standard?
There was a problem hiding this comment.
Yeh, there should be space. It is not in version 1.0.0 of zend-coding-standard unfortunately but it is coming with big upgrade ;-)
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2017
[v2.0] [BC Break] Rewrite library with ConsoleHelper + tests
weierophinney
added a commit
that referenced
this pull request
Feb 22, 2017
|
Thanks a ton for this, @webimpress! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite library with ConsoleHelper + tests.
Rebase needed after releasing v1.1.1 with fixes #5, #6, #7.
These changes provide new script:
Commands:
help- display help/usage messageenable- enable composer autoloading for the moduledisable- disbale composer autoloading for the moduleOptions are the same as previously:
--help|-h- display help/usage message--composer|-c- composer binary path; defaults composer--type|-t- module autoloading type to use--modules-path|-p- path to directory with modulesAlso added full test coverage. Please enable coveralls for the repository.
Note
This version will be used in zendframework/zend-expressive-tooling#12 as it provides functionality also to disable module's composer autoloading.