This repository has been archived by the owner on Jan 21, 2020. It is now read-only.
add oauth2 response format #72
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| */ | ||
| public function setApiProblemErrorResponse($apiProblemErrorResponse) | ||
| { | ||
| $this->apiProblemErrorResponse = $apiProblemErrorResponse; |
There was a problem hiding this comment.
Convert incoming variable to (bool)
|
@ezimuel Can you please review? Having this option for reporting seems like a good interoperability move. |
|
hey, what about this feature? |
| $parameters['error'] | ||
| ) | ||
| ); | ||
| return $this->getApiProblemResponse($response); |
There was a problem hiding this comment.
Shouldn't this be $this->getErrorResponse($response);?
There was a problem hiding this comment.
Never mind; this particular problem is not handled by the oauth2 spec, so it can and should be in a different format.
weierophinney
added a commit
that referenced
this pull request
Mar 30, 2015
…ntent_type add oauth2 response format Conflicts: config/module.config.php
weierophinney
added a commit
that referenced
this pull request
Mar 30, 2015
|
Merged to develop for release with 1.1. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #71
add oauth2 response format configurable, default api problem is set for BC.
fix bug with lack of mapping AUTHORIZATION header