-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drop Python 3.6 support #69
Conversation
Codecov Report
@@ Coverage Diff @@
## master #69 +/- ##
=======================================
Coverage 91.01% 91.01%
=======================================
Files 5 5
Lines 345 345
Branches 62 62
=======================================
Hits 314 314
Misses 20 20
Partials 11 11 Continue to review full report at Codecov.
|
I also find it troublesome to keep supporting Python 3.6 code and increasingly run into dependency issues. However, two clusters on which we work (with |
I agree, this is somewhat similar. Scikit-HEP has a good statement on it, most notably that some are dropping it already and more to follow. I would suggest to just go ahead with it and drop then. It still can be run on Python 3.6, but it won't receive any updates. I think the burden of this legacy to keep the versions in is just too large in the end and rather hampers the actual developement. In case there are crucial bugs, one could still think of backporting them oc if really needed. |
Just discussed this a bit with @wgradl, who had similar thoughts on Python 3.6 in RHEL8 and streams as referred to in the Scikit-HEP statement. We'll further discuss this in the group tomorrow, but it seems like it's fine to move on to 3.7+. |
Speaking for LHCb we're focusing on Python 3.9 for now for next year's stacks :-). At this point, when forgetting about Python 2, there isn't indeed no reason not to go with a very recent version, and 3.8 is about the minimum anyway. |
Great, LGTM! |
End of live is in December, so we can drop it (it's causing issues in #63 as dependencies dropped 3.6 already)
@redeboer is that fine? I assume that tensorwaves will also soon drop it?