review comment

zhaosongzs · Apr 26, 2024 · 7ba90af · 7ba90af
1 parent af736f5
commit 7ba90af
Showing 1 changed file with 13 additions and 1 deletion.
diff --git a/issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java b/issuetracker/src/main/java/org/openjdk/skara/issuetracker/jira/JiraIssue.java
@@ -39,6 +39,7 @@ public class JiraIssue implements IssueTrackerIssue {
     private final JiraProject jiraProject;
     private final RestRequest request;
     private final JSONValue json;
+    private final boolean needSecurity;
 
     private final Logger log = Logger.getLogger("org.openjdk.skara.issuetracker.jira");
 
@@ -54,6 +55,7 @@ public class JiraIssue implements IssueTrackerIssue {
         this.labels = json.get("fields").get("labels").stream()
                 .map(s -> new Label(s.asString()))
                 .collect(Collectors.toList());
+        this.needSecurity = jiraProject.jiraHost().visibilityRole().isPresent();
     }
 
     @Override
@@ -84,6 +86,11 @@ public String title() {
 
     @Override
     public void setTitle(String title) {
+        if (needSecurity) {
+            log.warning("Issue title does not support setting a visibility role - ignoring");
+            return;
+        }
+
         var query = JSON.object()
                         .put("fields", JSON.object()
                                            .put("summary", title));
@@ -101,6 +108,11 @@ public String body() {
 
     @Override
     public void setBody(String body) {
+        if (needSecurity) {
+            log.warning("Issue body does not support setting a visibility role - ignoring");
+            return;
+        }
+
         var query = JSON.object()
                         .put("fields", JSON.object()
                                            .put("description", body));
@@ -479,7 +491,7 @@ private void addWebLinkAsComment(Link link) {
     }
 
     private void addWebLink(Link link) {
-        if (jiraProject.jiraHost().visibilityRole().isPresent()) {
+        if () {
             addWebLinkAsComment(link);
             return;
         }