fix(chart): import types from package, not monorepo (#122)

* fix(chart): import types from package, not monorepo * build: ensure fresh directories on build * fix(chart): nix type deep import
zhaoyongjie · Nov 26, 2021 · 12ce877 · 12ce877
1 parent 183547b
commit 12ce877
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/superset-frontend/temporary_superset_ui/superset-ui/package.json b/superset-frontend/temporary_superset_ui/superset-ui/package.json
@@ -6,8 +6,8 @@
   "scripts": {
     "bootstrap": "lerna bootstrap",
     "build": "yarn run build:cjs && yarn run build:esm && yarn run type:dts && yarn run build:assets",
-    "build:cjs": "NODE_ENV=production beemo babel --extensions=\".js,.jsx,.ts,.tsx\" ./src --out-dir lib/ --minify --workspaces=\"@superset-ui/!(demo|generator-superset)\"",
-    "build:esm": "NODE_ENV=production beemo babel --extensions=\".js,.jsx,.ts,.tsx\" ./src --out-dir esm/ --esm --minify --workspaces=\"@superset-ui/!(demo|generator-superset)\"",
+    "build:cjs": "NODE_ENV=production beemo babel --extensions=\".js,.jsx,.ts,.tsx\" ./src --out-dir lib/ --delete-dir-on-start --minify --workspaces=\"@superset-ui/!(demo|generator-superset)\"",
+    "build:esm": "NODE_ENV=production beemo babel --extensions=\".js,.jsx,.ts,.tsx\" ./src --out-dir esm/ --delete-dir-on-start --esm --minify --workspaces=\"@superset-ui/!(demo|generator-superset)\"",
     "build:assets": "node ./scripts/buildAssets.js",
     "commit": "git-cz",
     "type": "NODE_ENV=production beemo typescript --workspaces=\"@superset-ui/!(generator-superset)\" --noEmit",

diff --git a/...y_superset_ui/superset-ui/packages/superset-ui-chart/src/components/ChartDataProvider.tsx b/...y_superset_ui/superset-ui/packages/superset-ui-chart/src/components/ChartDataProvider.tsx
@@ -1,6 +1,6 @@
 /* eslint react/sort-comp: 'off' */
 import React, { ReactNode } from 'react';
-import { SupersetClientInterface, RequestConfig } from '../../../superset-ui-connection/src/types';
+import { SupersetClientInterface, RequestConfig } from '@superset-ui/connection';
 
 import ChartClient, { SliceIdAndOrFormData } from '../clients/ChartClient';
 import { ChartFormData } from '../types/ChartFormData';