Add unit test for generator to keep 100% coverage (#89)

zhaoyongjie · Nov 24, 2021 · 57ecd12 · 57ecd12
1 parent 8dc9979
commit 57ecd12
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 7 deletions.
diff --git a/...temporary_superset_ui/superset-ui/packages/generator-superset/generators/package/index.js b/...temporary_superset_ui/superset-ui/packages/generator-superset/generators/package/index.js
@@ -18,6 +18,7 @@ module.exports = class extends Generator {
         type: 'list',
         name: 'language',
         message: 'Choose language',
+        default: 'typescript',
         choices: [
           {
             name: 'typescript',

diff --git a/...t-frontend/temporary_superset_ui/superset-ui/packages/generator-superset/test/app.test.js b/...t-frontend/temporary_superset_ui/superset-ui/packages/generator-superset/test/app.test.js
@@ -15,7 +15,7 @@ describe('generator-superset:app', () => {
   });
 
   it('creates files', () => {
-    assert.file(['package.json', 'README.md', 'src/index.js', 'test/index.test.js']);
+    assert.file(['package.json', 'README.md', 'src/index.ts', 'test/index.test.ts']);
   });
 
   /*

diff --git a/...ontend/temporary_superset_ui/superset-ui/packages/generator-superset/test/package.test.js b/...ontend/temporary_superset_ui/superset-ui/packages/generator-superset/test/package.test.js
@@ -7,15 +7,32 @@ describe('generator-superset:package', () => {
 
   beforeAll(() => {
     dir = process.cwd();
+  });
+
+  describe('typescript', () => {
+    beforeAll(() =>
+      helpers
+        .run(path.join(__dirname, '../generators/package'))
+        .withPrompts({ name: 'my-package', language: 'typescript' })
+        .withOptions({ skipInstall: true }),
+    );
 
-    return helpers
-      .run(path.join(__dirname, '../generators/package'))
-      .withPrompts({ name: 'my-package' })
-      .withOptions({ skipInstall: true });
+    it('creates files', () => {
+      assert.file(['package.json', 'README.md', 'src/index.ts', 'test/index.test.ts']);
+    });
   });
 
-  it('creates files', () => {
-    assert.file(['package.json', 'README.md', 'src/index.js', 'test/index.test.js']);
+  describe('javascript', () => {
+    beforeAll(() =>
+      helpers
+        .run(path.join(__dirname, '../generators/package'))
+        .withPrompts({ name: 'my-package', language: 'javascript' })
+        .withOptions({ skipInstall: true }),
+    );
+
+    it('creates files', () => {
+      assert.file(['package.json', 'README.md', 'src/index.js', 'test/index.test.js']);
+    });
   });
 
   /*