fix(plugin-chart-table): check if control values are set (apache#1095)

zhaoyongjie · Nov 25, 2021 · 5df9a17 · 5df9a17
1 parent bb570df
commit 5df9a17
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/...rontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/controlPanel.tsx b/...rontend/temporary_superset_ui/superset-ui/plugins/plugin-chart-table/src/controlPanel.tsx
@@ -198,7 +198,7 @@ const config: ControlPanelConfig = {
             name: 'row_limit',
             override: {
               visibility: ({ controls }: ControlPanelsContainerProps) =>
-                !controls.server_pagination.value,
+                !controls?.server_pagination?.value,
             },
           },
           {
@@ -211,7 +211,7 @@ const config: ControlPanelConfig = {
               choices: PAGE_SIZE_OPTIONS,
               description: t('Rows per page, 0 means no pagination'),
               visibility: ({ controls }: ControlPanelsContainerProps) =>
-                Boolean(controls.server_pagination.value),
+                Boolean(controls?.server_pagination?.value),
             },
           },
         ],
@@ -287,7 +287,7 @@ const config: ControlPanelConfig = {
               choices: PAGE_SIZE_OPTIONS,
               description: t('Rows per page, 0 means no pagination'),
               visibility: ({ controls }: ControlPanelsContainerProps) =>
-                !controls.server_pagination.value,
+                !controls?.server_pagination?.value,
             },
           },
           null,