fix(plugin-chart-echarts): fix legend margin in radar and ts chart (a…

…pache#1470)
zhaoyongjie · Nov 24, 2021 · e93873f · e93873f
1 parent 69808c2
commit e93873f
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/...emporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Radar/transformProps.ts b/...emporary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Radar/transformProps.ts
@@ -39,6 +39,7 @@ import {
 import { DEFAULT_LEGEND_FORM_DATA } from '../types';
 import {
   extractGroupbyLabel,
+  getChartPadding,
   getColtypesMapping,
   getLegendProps,
 } from '../utils/series';
@@ -82,6 +83,7 @@ export default function transformProps(
     labelPosition,
     legendOrientation,
     legendType,
+    legendMargin,
     metrics = [],
     numberFormat,
     dateFormat,
@@ -201,6 +203,7 @@ export default function transformProps(
   const series: RadarSeriesOption[] = [
     {
       type: 'radar',
+      ...getChartPadding(showLegend, legendOrientation, legendMargin),
       animation: false,
       emphasis: {
         label: {

diff --git a/...ary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts b/...ary_superset_ui/superset-ui/plugins/plugin-chart-echarts/src/Timeseries/transformProps.ts
@@ -89,6 +89,7 @@ export default function transformProps(
     forecastEnabled,
     legendOrientation,
     legendType,
+    legendMargin,
     logAxis,
     markerEnabled,
     markerSize,
@@ -245,7 +246,7 @@ export default function transformProps(
     legendOrientation,
     addYAxisLabelOffset,
     zoomable,
-    null,
+    legendMargin,
     addXAxisLabelOffset,
     yAxisTitlePosition,
     yAxisTitleMargin,