Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

L390 Tablet mode calls event 0x60f0:0 #71

Merged
merged 5 commits into from
Nov 21, 2020
Merged

L390 Tablet mode calls event 0x60f0:0 #71

merged 5 commits into from
Nov 21, 2020

Conversation

antoniomcr96
Copy link
Contributor

Other info here: #68
I'm opening this pull request in order to hide the message. I hope it won't interfere with other thinkpads.

According to issue #68, just to remember that rotating the screen in tablet mode calls this event on L390 Yoga
According to #68 if I rotate my screen (L390 Yoga) I see event 0x60F0:0 (both on opening and closing). This should hide the event
@zhen-zen
Copy link
Owner

Yoga Mode change should be notified on another interface. And the thermal change notification is sent since tablet mode etc requires different thermal policies.

@antoniomcr96
Copy link
Contributor Author

antoniomcr96 commented Nov 18, 2020

Yoga Mode change should be notified on another interface. And the thermal change notification is sent since tablet mode etc requires different thermal policies.

I understand, it makes sense. Maybe only:
TP_HKEY_EV_THM_TRANSFM_CHANGED.rawValue: [0: EventDesc("Thermal Change", display: false)] // 0x60F0
Display: false should hide the message, I think.

If it's ok for you I'll update the pull request

After university exam I'll try to find out how to use debug version and what is the specific event for tablet mode on my laptop.

@zhen-zen
Copy link
Owner

Sure.

And the implementation for Idea variant is in https://github.com/zhen-zen/YogaSMC/blob/master/YogaSMC/YogaWMI/IdeaWMI.cpp#L89. Maybe they will reuse the same ACPI code.

@zhen-zen zhen-zen merged commit eae7261 into zhen-zen:master Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants