Gracefully handle empty "xstyle" prop values (facebook#23190)

zhengjitf · Apr 15, 2022 · 0c9b5a1 · 0c9b5a1
1 parent f6caca7
commit 0c9b5a1
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 0 deletions.
diff --git a/packages/react-devtools-shared/src/backend/StyleX/__tests__/utils-test.js b/packages/react-devtools-shared/src/backend/StyleX/__tests__/utils-test.js
@@ -33,6 +33,29 @@ describe('Stylex plugin utils', () => {
     });
   });
 
+  it('should gracefully handle empty values', () => {
+    expect(getStyleXData(null)).toMatchInlineSnapshot(`
+      Object {
+        "resolvedStyles": Object {},
+        "sources": Array [],
+      }
+    `);
+
+    expect(getStyleXData(undefined)).toMatchInlineSnapshot(`
+      Object {
+        "resolvedStyles": Object {},
+        "sources": Array [],
+      }
+    `);
+
+    expect(getStyleXData('')).toMatchInlineSnapshot(`
+      Object {
+        "resolvedStyles": Object {},
+        "sources": Array [],
+      }
+    `);
+  });
+
   it('should support simple style objects', () => {
     defineStyles(`
       .foo {

diff --git a/packages/react-devtools-shared/src/backend/StyleX/utils.js b/packages/react-devtools-shared/src/backend/StyleX/utils.js
@@ -29,6 +29,10 @@ export function crawlData(
   sources: Set<string>,
   resolvedStyles: Object,
 ): void {
+  if (data == null) {
+    return;
+  }
+
   if (isArray(data)) {
     data.forEach(entry => {
       if (isArray(entry)) {