Skip to content

Commit

Permalink
Implement getServerSnapshot in userspace shim (facebook#22359)
Browse files Browse the repository at this point in the history
* Convert useSES shim tests to use React DOM

Idea is that eventually we'll run these tests against an actual build of
React DOM 17 to test backwards compatibility.

* Implement getServerSnapshot in userspace shim

If the DOM is not present, we assume that we are running in a server
environment and return the result of `getServerSnapshot`.

This heuristic doesn't work in React Native, so we'll need to provide
a separate native build (using the `.native` extension). I've left this
for a follow-up.

We can't call `getServerSnapshot` on the client, because in versions of
React before 18, there's no built-in mechanism to detect whether we're
hydrating. To avoid a server mismatch warning, users must account for
this themselves and return the correct value inside `getSnapshot`.

Note that none of this is relevant to the built-in API that is being
added in 18. This only affects the userspace shim that is provided
for backwards compatibility with versions 16 and 17.
  • Loading branch information
acdlite authored and zhengjitf committed Apr 15, 2022
1 parent 46827af commit e46efac
Show file tree
Hide file tree
Showing 4 changed files with 264 additions and 75 deletions.
Loading

0 comments on commit e46efac

Please sign in to comment.