fix: remove duplicate handleError in Video

zhihu · Sep 8, 2021 · a6aaa4c · a6aaa4c
1 parent 2d51fea
commit a6aaa4c
Showing 1 changed file with 8 additions and 14 deletions.
diff --git a/packages/griffith/src/components/Video.js b/packages/griffith/src/components/Video.js
@@ -221,20 +221,6 @@ class Video extends Component {
     }
   }
 
-  handleError = () => {
-    const {onError} = this.props
-    if (this.isSwitchDefinition) {
-      this.isSwitchDefinition = false
-      this.props.onEvent(
-        EVENTS.PLAYER.CHANGE_QUALITY_FAIL,
-        this.props.currentQuality
-      )
-    }
-    if (onError) {
-      onError(this.root.error)
-    }
-  }
-
   handleDurationChange = () => {
     const {onDurationChange} = this.props
     if (onDurationChange) {
@@ -313,6 +299,14 @@ class Video extends Component {
     if (!dontReportPlayFailed) {
       this.props.onEvent(EVENTS.PLAYER.PLAY_FAILED, {currentTime})
     }
+
+    if (this.isSwitchDefinition) {
+      this.isSwitchDefinition = false
+      this.props.onEvent(
+        EVENTS.PLAYER.CHANGE_QUALITY_FAIL,
+        this.props.currentQuality
+      )
+    }
     this.props.onError(error)
   }