chore: fix hook deps

zhihu · Mar 9, 2022 · ec8c661 · ec8c661
1 parent 9adcf32
commit ec8c661
Showing 1 changed file with 7 additions and 8 deletions.
diff --git a/packages/griffith/src/components/Player.tsx b/packages/griffith/src/components/Player.tsx
@@ -227,14 +227,6 @@ const InnerPlayer: React.FC<InnerPlayerProps> = ({
     }
   }, [emitEvent, showController])
 
-  const preSources = usePrevious(sources)
-  useEffect(() => {
-    if (preSources && preSources !== sources) {
-      handleSeek(0)
-    }
-    // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [sources])
-
   // sync document title
   useEffect(() => {
     if (
@@ -491,6 +483,13 @@ const InnerPlayer: React.FC<InnerPlayerProps> = ({
     onSeek: handleSeek,
   })
 
+  const prevSources = usePrevious(sources)
+  useEffect(() => {
+    if (prevSources && prevSources !== sources) {
+      handleSeek(0)
+    }
+  }, [handleSeek, prevSources, sources])
+
   const isPip = Boolean(Pip.pictureInPictureElement)
   // Safari 会将 pip 状态视为全屏
   const isFullScreen = Boolean(BigScreen.element) && !isPip