Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mobile muted #128

Merged
merged 1 commit into from
May 26, 2020
Merged

fix: mobile muted #128

merged 1 commit into from
May 26, 2020

Conversation

xiaoyuhen
Copy link
Contributor

fix: mobile muted

Description

Mobile device use the browser's default video controls, we don't need to handle onVolumeChange event

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • Allow the mobile user to control video volume

@codecov-commenter
Copy link

Codecov Report

Merging #128 into master will increase coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #128      +/-   ##
==========================================
+ Coverage   50.42%   50.50%   +0.08%     
==========================================
  Files         124      124              
  Lines        1773     1770       -3     
==========================================
  Hits          894      894              
+ Misses        879      876       -3     
Impacted Files Coverage Δ
packages/griffith/src/components/Player/Player.js 0.00% <ø> (ø)
packages/griffith/src/components/Video/Video.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 812fefb...a30d206. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit fa3a8fd into zhihu:master May 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants