Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: picture in picture #136

Merged
merged 2 commits into from
Aug 20, 2020
Merged

feat: picture in picture #136

merged 2 commits into from
Aug 20, 2020

Conversation

kitayoshi
Copy link
Collaborator

@kitayoshi kitayoshi commented Aug 20, 2020

Picture in Picture for supported broswer

image

pip button

image

pip enabled

Description

  • Add a PipButtonItem and icons for it
  • Add a simple utils/pip.js to implement pip feature
  • Add ENTER_PIP and EXIT_PIP events

How Has This Been Tested?

Tested in Safari 13.1.1 and Chrome 84.0 on macOS 10.15.5

  • enter pip by click button
  • exit pip by click button
  • exit pip by native button

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

Codecov Report

Merging #136 into master will decrease coverage by 0.84%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #136      +/-   ##
==========================================
- Coverage   50.50%   49.66%   -0.85%     
==========================================
  Files         124      126       +2     
  Lines        1770     1800      +30     
==========================================
  Hits          894      894              
- Misses        876      906      +30     
Impacted Files Coverage Δ
...s/griffith/src/components/Controller/Controller.js 0.00% <ø> (ø)
...h/src/components/Controller/items/PipButtonItem.js 0.00% <0.00%> (ø)
packages/griffith/src/components/Player/Player.js 0.00% <0.00%> (ø)
.../src/components/PlayerContainer/PlayerContainer.js 0.00% <ø> (ø)
packages/griffith/src/utils/pip.js 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3a8fd...d3854bd. Read the comment docs.

@kitayoshi kitayoshi linked an issue Aug 20, 2020 that may be closed by this pull request
@xiaoyuhen xiaoyuhen merged commit f4cc4e5 into zhihu:master Aug 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Picture-in-picture mode support
3 participants