Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add node information on the progress bar #154

Merged
merged 2 commits into from
Apr 19, 2021
Merged

Conversation

Lisuhan
Copy link
Contributor

@Lisuhan Lisuhan commented Apr 19, 2021

Pull Request Template

Description

image
在流程条上面提供 progressDot 属性, 支持视频节点的展示

How Has This Been Tested?

  • example 界面可以正常展示

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-commenter
Copy link

codecov-commenter commented Apr 19, 2021

Codecov Report

Merging #154 (4ff74c5) into master (79543bc) will decrease coverage by 0.02%.
The diff coverage is 50.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #154      +/-   ##
==========================================
- Coverage   49.12%   49.09%   -0.03%     
==========================================
  Files         126      127       +1     
  Lines        1820     1825       +5     
==========================================
+ Hits          894      896       +2     
- Misses        926      929       +3     
Impacted Files Coverage Δ
...s/griffith/src/components/Controller/Controller.js 0.00% <ø> (ø)
packages/griffith/src/components/Player/Player.js 0.00% <ø> (ø)
.../src/components/PlayerContainer/PlayerContainer.js 0.00% <ø> (ø)
...griffith/src/components/ProgressDot/ProgressDot.js 40.00% <40.00%> (ø)
packages/griffith/src/components/Slider/Slider.js 30.13% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79543bc...4ff74c5. Read the comment docs.

packages/griffith/README-zh-Hans.md Outdated Show resolved Hide resolved
packages/griffith/src/components/Slider/Slider.js Outdated Show resolved Hide resolved
@ambar ambar merged commit 48a2f95 into zhihu:master Apr 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants