Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix fullscreen related issues #19

Merged
merged 4 commits into from
Mar 25, 2019
Merged

Conversation

wangcheng
Copy link
Contributor

Description

  • replace bigscreen with isomorphic-bigscreen which is safe for server-side use
  • fix a bug where a player ref is missing
  • fix a bug that fullscreen event listeners are mistakenly added to global.
  • remove a redundant emitEvent prop

Fixes #15

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@wangcheng wangcheng added bug🐛 Something isn't working enhancement✨ New feature or request labels Mar 24, 2019
@codecov-io
Copy link

codecov-io commented Mar 24, 2019

Codecov Report

Merging #19 into master will increase coverage by 0.16%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
+ Coverage   53.16%   53.32%   +0.16%     
==========================================
  Files         123      123              
  Lines        1657     1652       -5     
==========================================
  Hits          881      881              
+ Misses        776      771       -5
Impacted Files Coverage Δ
...th/src/contexts/VideoSource/VideoSourceProvider.js 0% <ø> (ø) ⬆️
.../src/components/PlayerContainer/PlayerContainer.js 0% <0%> (ø) ⬆️
packages/griffith/src/components/Player/Player.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 694ad04...7366677. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 7df92e7 into zhihu:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working enhancement✨ New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace bigscreen
3 participants