Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add defaultQualityOrder prop #283

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Conversation

xia5517
Copy link
Contributor

@xia5517 xia5517 commented Sep 26, 2022

Pull Request Template

Description

default rule of qualities is ['auto', 'ld', 'sd', 'hd', 'fhd'],allow reverse when decQualities = true

Fixes # (issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Please also note any relevant details for your test configuration.

  • yarn link in project

@@ -99,6 +99,7 @@ type OuterPlayerProps = {
messageContextRef?: React.MutableRefObject<MessageContextValue | void>
initialObjectFit?: ObjectFit
defaultQuality?: RealQuality
decQualities?: boolean
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

改名。
注释:缺省清晰度的选择方式之类

@ambar ambar changed the title feat: support decQualities feat: add defaultQualityOrder prop Sep 27, 2022
@ambar ambar merged commit 2c306be into zhihu:master Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants