Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: empty audio track #52

Merged
merged 1 commit into from
Apr 1, 2019
Merged

fix: empty audio track #52

merged 1 commit into from
Apr 1, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 1, 2019

fix: empty audio track

Description

In some case, we have empty edit media time, If we dont ignore the empty edit media time, we will have audio/video sync problem. see #14

image

How Has This Been Tested?

  • this video can play normally
  • the example video can play normally

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-io
Copy link

codecov-io commented Apr 1, 2019

Codecov Report

Merging #52 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #52   +/-   ##
=======================================
  Coverage   52.86%   52.86%           
=======================================
  Files         123      123           
  Lines        1678     1678           
=======================================
  Hits          887      887           
  Misses        791      791
Impacted Files Coverage Δ
packages/griffith-mp4/src/mp4/mp4Probe.js 0% <ø> (ø) ⬆️
packages/griffith-mp4/src/mse/controller.js 0% <ø> (ø) ⬆️
...s/griffith-mp4/src/mp4/utils/getSamplesInterval.js 95.08% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 67d37bb...10853ba. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit a62ef4d into zhihu:master Apr 1, 2019
@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 1, 2019
@xiaoyuhen xiaoyuhen deleted the audio branch April 1, 2019 12:13
@xiaoyuhen xiaoyuhen mentioned this pull request Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants