Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use xhr instead of the fetch api #56

Merged
merged 2 commits into from
Apr 3, 2019
Merged

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 3, 2019

fix: use xhr instead of the fetch api

Description

AbortController only support Chrome 66+, so we use xhr instead of the fetch api.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 3, 2019
@codecov-io
Copy link

codecov-io commented Apr 3, 2019

Codecov Report

Merging #56 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   52.86%   52.57%   -0.29%     
==========================================
  Files         123      123              
  Lines        1678     1687       +9     
==========================================
  Hits          887      887              
- Misses        791      800       +9
Impacted Files Coverage Δ
packages/griffith-mp4/src/fetch.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 110a612...c5ee277. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 267b56a into zhihu:master Apr 3, 2019
@xiaoyuhen xiaoyuhen deleted the chrome@49 branch April 3, 2019 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants