Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a hls bug when switching quality #59

Merged
merged 2 commits into from
Apr 10, 2019
Merged

Conversation

wangcheng
Copy link
Contributor

@wangcheng wangcheng commented Apr 8, 2019

Pull Request Template

Description

使用 hls 插件的时候,外层不应该处理 src 改变的事件。

所以改变了一下插件的结构,这样 Video 判断是否需要跳过 src 改变时的相关逻辑

Fixes #50

How Has This Been Tested?

  • hls 可以播放,可以切换清晰度
  • 其他模式正常

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-io
Copy link

Codecov Report

Merging #59 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #59     +/-   ##
=========================================
- Coverage    52.2%   52.11%   -0.1%     
=========================================
  Files         123      123             
  Lines        1699     1702      +3     
=========================================
  Hits          887      887             
- Misses        812      815      +3
Impacted Files Coverage Δ
...kages/griffith/src/components/Video/NormalVideo.js 0% <0%> (ø) ⬆️
packages/griffith/src/components/Video/Video.js 0% <0%> (ø) ⬆️
packages/griffith-hls/src/Video.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e295326...0ade4b0. Read the comment docs.

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 8, 2019
@xiaoyuhen xiaoyuhen merged commit 4a0e079 into zhihu:master Apr 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants