Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont show Controller component when first frame is not ready #74

Merged
merged 1 commit into from
Apr 18, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 18, 2019

fix: don't show Controller component when the first frame is not ready

Description

If the user executes seek action when the fist frame is not ready, will throw some error.

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #74 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master     #74   +/-   ##
======================================
  Coverage    51.5%   51.5%           
======================================
  Files         123     123           
  Lines        1722    1722           
======================================
  Hits          887     887           
  Misses        835     835
Impacted Files Coverage Δ
packages/griffith/src/components/Player/Player.js 0% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update be4d309...8224302. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 5f3c621 into zhihu:master Apr 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants