Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: exceeding the buffering quota #75

Merged
merged 2 commits into from
Apr 18, 2019
Merged

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 18, 2019

fix: exceeding the buffering quota

Description

If SourceBuffer has too much data in it, calling SourceBuffer.appendBuffer() will trigger the following message in the Chrome console window.

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 18, 2019
@codecov-io
Copy link

codecov-io commented Apr 18, 2019

Codecov Report

Merging #75 into master will decrease coverage by 0.59%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #75     +/-   ##
=========================================
- Coverage    51.5%   50.91%   -0.6%     
=========================================
  Files         123      124      +1     
  Lines        1722     1742     +20     
=========================================
  Hits          887      887             
- Misses        835      855     +20
Impacted Files Coverage Δ
packages/griffith-mp4/src/mse/polyfill.js 0% <0%> (ø)
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5f3c621...4e440d2. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 01134f1 into zhihu:master Apr 18, 2019
@xiaoyuhen xiaoyuhen deleted the full-buffer branch April 18, 2019 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants