Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot read property start of undefined #86

Merged
merged 1 commit into from
Apr 25, 2019
Merged

fix: cannot read property start of undefined #86

merged 1 commit into from
Apr 25, 2019

Conversation

xiaoyuhen
Copy link
Contributor

@xiaoyuhen xiaoyuhen commented Apr 25, 2019

fix: cannot read property start of undefined

Description

close #46

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@xiaoyuhen xiaoyuhen added the bug🐛 Something isn't working label Apr 25, 2019
@codecov-io
Copy link

codecov-io commented Apr 25, 2019

Codecov Report

Merging #86 into master will decrease coverage by 0.28%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #86      +/-   ##
==========================================
- Coverage   50.76%   50.48%   -0.29%     
==========================================
  Files         124      124              
  Lines        1759     1769      +10     
==========================================
  Hits          893      893              
- Misses        866      876      +10
Impacted Files Coverage Δ
.../griffith-mp4/src/mp4/utils/getFragmentPosition.js 0% <0%> (ø) ⬆️
packages/griffith-mp4/src/mp4/mp4Probe.js 0% <0%> (ø) ⬆️
packages/griffith-mp4/src/player.js 0% <0%> (ø) ⬆️
packages/griffith-mp4/src/mse/controller.js 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a392a72...1167814. Read the comment docs.

@xiaoyuhen xiaoyuhen merged commit 9e2740a into master Apr 25, 2019
@xiaoyuhen xiaoyuhen deleted the start branch April 26, 2019 03:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug🐛 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read property 'start' of undefined
2 participants